[CI] Skip CI for non-runtime directories#7870
Conversation
|
/skip-ci ci_iluvatar |
|
Thanks for your contribution! |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
EmmonsCurse
force-pushed
the
ci_optimize_dev_0520
branch
from
05f3165 to
754bd24
Compare
EmmonsCurse
force-pushed
the
ci_optimize_dev_0520
branch
from
754bd24 to
7c2846f
Compare
CI报告基于以下代码生成（30分钟更新一次）: 1 任务总览Required 任务当前无失败、无运行中、无等待中；本 PR 属于 CI skip 规则调整，部分测试任务按跳过逻辑被跳过。建议重点关注 Optional 失败任务是否需要人工确认；Required 侧暂无阻塞。
2 任务状态汇总2.1 Required任务 : 2/10 通过
2.2 可选任务 — 22/32 通过
3 失败详情（仅 required）无 required 失败任务。本次未调用深度失败分析；Optional 失败任务不阻塞合并，仅在上方可选任务区展示。 |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
/skip-ci all |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
EmmonsCurse
changed the title
EmmonsCurse
force-pushed
the
ci_optimize_dev_0520
branch
from
c5c2e5f to
9fd57f7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
PaddlePaddle-bot
left a comment
PaddlePaddle-bot
left a comment
There was a problem hiding this comment.
🤖 Paddle-CI-Agent | pr_review |
2026-06-17 17:14:02
📋 Review 摘要
PR 概述：调整 check-bypass.yml 的 docs-only/非运行时目录跳过规则。
变更范围：.github/workflows/check-bypass.yml
影响面 Tag：[CI]
问题
| 级别 | 文件 | 概述 |
|---|---|---|
| 🔴 Bug | .github/workflows/check-bypass.yml:75 |
目录级白名单会把包含构建脚本、Dockerfile、示例测试和 benchmark 代码的变更判定为 docs-only，从而跳过构建/测试 job |
📝 PR 规范检查
Checklist 中 "Add unit tests" 项未勾选且未在 PR 中说明原因，模板要求 "Please write the reason in this PR if no unit tests"。建议在描述中补充说明（如：本 PR 仅修改 CI 配置与文档，无需添加单元测试）。
标题建议：标题合规，无需修改。
PR 描述建议（点击展开，可直接复制）
## Motivation
Changes under documentation, tooling, benchmark, and auxiliary configuration directories do not affect runtime behavior directly. Running full CI for these modifications increases unnecessary resource usage and slows down development workflow.
Additionally, Claude skill documentation for FastDeploy unit test writing is added to improve development guidance and workflow standardization.
## Modifications
- Added CI skip rules for changes under:
- `.claude/`
- `benchmarks/`
- `docs/`
- `dockerfiles/`
- `examples/`
- `tools/`
- Added:
- `.claude/skills/write-fastdeploy-unittest/SKILL.md`
- `.claude/skills/write-fastdeploy-unittest/README.md`
- Reduced unnecessary CI triggering for non-runtime related changes.
## Usage or Command
N/A
## Accuracy Tests
N/A
## Checklist
- [x] Add at least a tag in the PR title.
- Tag list: [`[FDConfig]`,`[APIServer]`,`[Engine]`, `[Scheduler]`, `[PD Disaggregation]`, `[Executor]`, `[Graph Optimization]`, `[Speculative Decoding]`, `[RL]`, `[Models]`, `[Quantization]`, `[Loader]`, `[OP]`, `[KVCache]`, `[DataProcessor]`, `[BugFix]`, `[Docs]`, `[CI]`, `[Optimization]`, `[Feature]`, `[Benchmark]`, `[Others]`, `[XPU]`, `[HPU]`, `[GCU]`, `[DCU]`, `[Iluvatar]`, `[Metax]`]
- You can add new tags based on the PR content, but the semantics must be clear.
- [x] Format your code, run `pre-commit` before commit.
- [ ] Add unit tests. Please write the reason in this PR if no unit tests.
- 本 PR 仅修改 CI 配置与文档文件（`.github/workflows/` 和 `.claude/skills/`），无需添加单元测试。
- [ ] Provide accuracy results.
- [ ] If the current PR is submitting to the `release` branch, make sure the PR has been submitted to the `develop` branch, then cherry-pick it to the `release` branch with the `[Cherry-Pick]` PR tag.总体评价
本次变更会扩大 can-skip-docs 的触发范围，但新增目录中存在会影响构建、镜像、示例执行和 benchmark 行为的文件类型。建议先收窄跳过规则，只对明确低风险的文档/说明类文件生效。
|
|
||
| can_skip_docs=true | ||
| for f in $files; do | ||
| if [[ "$f" =~ ^\.claude/ || "$f" =~ ^benchmarks/ || "$f" =~ ^docs/ || "$f" =~ ^dockerfiles/ || "$f" =~ ^examples/ || "$f" =~ ^tools/ ]]; then |
There was a problem hiding this comment.
🔴 Bug 这里把整个 benchmarks/、dockerfiles/、examples/、tools/ 目录都当成 docs-only 跳过，会漏跑真实构建/测试风险。
check-only-docs 的结果在后续 final-output 中会直接变成 can-skip=true，而 _build_linux.yml、_unit_test_coverage.yml、_build_xpu.yml 等 job 都用 needs.check_bypass.outputs.can-skip != 'true' 控制执行。当前仓库这些目录包含 tools/dockerfile/Dockerfile.ci、tools/deep_gemm_pre-compile/*.py、dockerfiles/Dockerfile.gpu、examples/.../test.sh 和 benchmarks/*.py 等可执行或构建相关文件；只要 PR 只改其中任意文件，就会跳过构建和测试，导致 runtime、镜像或示例脚本回归无法被 CI 捕获。
建议修复方式：
不要按目录整体 continue。把 docs-only 规则收敛为明确低风险文件类型/子路径，例如只允许 docs/**、.claude/**、以及这些目录中的 *.md 文档文件跳过；对 *.py、*.sh、Dockerfile*、requirements*.txt、*.yaml 等会影响执行、构建或环境的文件保持 can_skip_docs=false。
2 participants
Motivation
Changes under documentation, tooling, benchmark, and auxiliary configuration directories do not affect runtime behavior directly. Running full CI for these modifications increases unnecessary resource usage and slows down development workflow.
Modifications
.claude/benchmarks/docs/dockerfiles/examples/tools/Usage or Command
N/A
Accuracy Tests
N/A
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.